From 929afa7bcf14733884c0116e0c89783eaee42eee Mon Sep 17 00:00:00 2001 From: Stefano Stabellini Date: Thu, 8 Dec 2016 16:59:28 -0800 Subject: [PATCH] missing vgic_unlock_rank in gic_remove_irq_from_guest Add missing vgic_unlock_rank on the error path in gic_remove_irq_from_guest. Coverity-ID: 1381843 Signed-off-by: Stefano Stabellini Reviewed-by: Julien Grall --- xen/arch/arm/gic.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/xen/arch/arm/gic.c b/xen/arch/arm/gic.c index 63c744af8a..a5348f237a 100644 --- a/xen/arch/arm/gic.c +++ b/xen/arch/arm/gic.c @@ -205,7 +205,10 @@ int gic_remove_irq_from_guest(struct domain *d, unsigned int virq, */ if ( test_bit(_IRQ_INPROGRESS, &desc->status) || !test_bit(_IRQ_DISABLED, &desc->status) ) + { + vgic_unlock_rank(v_target, rank, flags); return -EBUSY; + } } clear_bit(_IRQ_GUEST, &desc->status); -- 2.30.2